GJL commented on a change in pull request #8603: [FLINK-12608][runtime] Add
getVertexOrThrow and
URL: https://github.com/apache/flink/pull/8603#discussion_r293238721
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/SchedulingTopology.java
##########
@@ -43,11 +43,33 @@
*/
Optional<SchedulingExecutionVertex> getVertex(ExecutionVertexID
executionVertexId);
+ /**
+ * Looks up the {@link SchedulingExecutionVertex} for the given {@link
ExecutionVertexID}.
+ *
+ * @param executionVertexId identifying the respective scheduling vertex
+ * @return The respective scheduling vertex or throw {@link Exception}
if the vertex does not exist
Review comment:
* It is misleading to write that we potentially throw `Exception` because
`IllegalArgumentException` is unchecked.
* You can use @throws tag
```
* @return The respective scheduling vertex
* @throws IllegalArgumentException If the vertex does not exist
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
