sunjincheng121 commented on issue #8684: [FLINK-12790] Implement KeyScope enum to distinguish the key of localKeyBy and general keyBy API URL: https://github.com/apache/flink/pull/8684#issuecomment-501593809 @yanghua Thanks for the PR! Just a suggestion from my points of views: A PR is usually a complete feature or bugfix, and the newly added feature will contain a complete test. So, can you merge this PR with your next follow-up PR, and make the changes more complete, and give the reviewer a global view. What do you think? Best, Jincheng
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
