shuai-xu commented on a change in pull request #7227: [FLINK-11059] [runtime]
do not add releasing failed slot to free slots
URL: https://github.com/apache/flink/pull/7227#discussion_r293271038
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolImpl.java
##########
@@ -773,15 +788,9 @@ private void checkIdleSlot() {
componentMainThreadExecutor,
(Acknowledge ignored, Throwable
throwable) -> {
if (throwable != null) {
- if
(registeredTaskManagers.contains(expiredSlot.getTaskManagerId())) {
-
log.debug("Releasing slot [{}] of registered TaskExecutor {} failed. " +
-
"Trying to fulfill a different slot request.", allocationID,
expiredSlot.getTaskManagerId(),
-
throwable);
-
tryFulfillSlotRequestOrMakeAvailable(expiredSlot);
- } else {
-
log.debug("Releasing slot [{}] failed and owning TaskExecutor {} is no " +
- "longer
registered. Discarding slot.", allocationID, expiredSlot.getTaskManagerId());
- }
+ // The slot status will
be synced to task manager in next heartbeat.
+ log.debug("Releasing
slot [{}] of registered TaskExecutor {} failed. Discarding slot.",
+
allocationID, expiredSlot.getTaskManagerId(), throwable);
Review comment:
I think it is not necessary now as the slot will soon be synced through
heartbeat (in less than 10s).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
