1u0 commented on a change in pull request #8602: [FLINK-12313] Add workaround
to avoid race condition in SynchronousCheckpointITCase test
URL: https://github.com/apache/flink/pull/8602#discussion_r293276087
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SynchronousCheckpointITCase.java
##########
@@ -108,6 +110,9 @@ public void initializeLatchesAndError() {
error.set(null);
}
+ @Rule
+ public final Timeout timeoutPerTest = Timeout.seconds(7);
Review comment:
I don't insist on 7 seconds at all, and as mentioned before, I'm open for
other values.
I just think that with too big timeouts (like 30 seconds and above), it's
more probable that something wrong with the test itself, rather with the
environment running it (**note:** we are discussing only this concrete test,
"YMMV" for other tests). In that case I'd prefer the test to fail reasonably
fast (even on CI, as it uses shared resources).
> LGTM % timeout. If you don't want to change it, let me know and I will
merge it,
If you want, **I can change it to 10 seconds before merging this PR**.
Otherwise, it looks like we are both not enforcing any specific value, so we
can leave it as is for now.
> but in that case please monitor jira issues if someone is reporting this
test as flaky.
I'll adjust the timeout (new or current) if needed and if I notice such
issue, but I don't promise to vigorously monitor jira issues for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
