beyond1920 commented on a change in pull request #8294:
[FLINK-12348][table-planner-blink]Use TableConfig in api module to replace
TableConfig in blink-planner module.
URL: https://github.com/apache/flink/pull/8294#discussion_r293280110
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
##########
@@ -24,6 +24,7 @@ import org.apache.flink.streaming.api.datastream.DataStream
import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment
import org.apache.flink.streaming.api.graph.{StreamGraph, StreamGraphGenerator}
import org.apache.flink.streaming.api.transformations.StreamTransformation
+import org.apache.flink.table.api.PlannerConfigImpl
Review comment:
Yes. However, Planner implementation in blink-planner module could see
PlannerConfigImpl. We could move parts to Planner implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
