JingsongLi commented on a change in pull request #8718:
[FLINK-12824][table-planner-blink] Set parallelism for stream SQL
URL: https://github.com/apache/flink/pull/8718#discussion_r293282778
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/plan/nodes/resource/parallelism/ParallelismProcessor.java
##########
@@ -51,13 +52,13 @@
/**
* Filter sink nodes because parallelism of sink nodes is calculated
after translateToPlan, as
- * transformations generated by BatchExecSink have too many uncertainty
factors. Filtering here
- * can let later process easier.
+ * transformations generated by {@link BatchExecSink} or {@link
StreamExecSink} have too many
+ * uncertainty factors. Filtering here can let later process easier.
*/
private List<ExecNode<?, ?>> filterSinkNodes(List<ExecNode<?, ?>>
sinkNodes) {
List<ExecNode<?, ?>> rootNodes = new ArrayList<>();
sinkNodes.forEach(s -> {
- if (s instanceof BatchExecSink) {
+ if (s instanceof BatchExecSink || s instanceof
StreamExecSink) {
Review comment:
Use `Sink`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
