tillrohrmann commented on a change in pull request #8698:
[FLINK-12669][runtime] Implement FixedDelayRestartBackoffTimeStrategy
URL: https://github.com/apache/flink/pull/8698#discussion_r293291481
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/RestartBackoffTimeStrategyOptions.java
##########
@@ -54,4 +54,23 @@
.key("restart-backoff-time-strategy.failure-rate.backoff-time")
.defaultValue("1 min")
.withDescription("Backoff time between two consecutive restart
attempts.");
+
+ /**
+ * Maximum number of attempts the fixed delay restart strategy will try
before failing a job.
+ */
+ @PublicEvolving
+ public static final ConfigOption<Integer>
RESTART_BACKOFF_TIME_STRATEGY_FIXED_DELAY_ATTEMPTS = ConfigOptions
+ .key("restart-backoff-time-strategy.fixed-delay.attempts")
+ .defaultValue(1)
+ .withDescription("Maximum number of attempts the fixed delay
restart strategy will try before failing a job.");
+
+ /**
+ * Backoff time between two consecutive restart attempts in
FixedDelayRestartBackoffTimeStrategy.
+ * It can be specified using Scala's FiniteDuration notation: "1 min",
"20 s".
+ */
+ @PublicEvolving
+ public static final ConfigOption<String>
RESTART_BACKOFF_TIME_STRATEGY_FIXED_DELAY_BACKOFF_TIME = ConfigOptions
+ .key("restart-backoff-time-strategy.fixed-delay.backoff-time")
+ .defaultValue("1 min")
Review comment:
I would be in favor of specifying the backoff time in milli seconds in order
to get eventually rid of Scala's `FiniteDuration`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
