pnowojski commented on a change in pull request #8692: [FLINK-12804] Introduce
mailbox-based ExecutorService
URL: https://github.com/apache/flink/pull/8692#discussion_r293292948
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxImpl.java
##########
@@ -158,44 +174,108 @@ public boolean tryPutMail(@Nonnull Runnable letter) {
}
@Override
- public void putMail(@Nonnull Runnable letter) throws
InterruptedException {
+ public void putMail(@Nonnull Runnable letter) throws
InterruptedException, MailboxStateException {
Review comment:
Shouldn't we add a checkstate that we are not putting something from the
mailbox thread?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
