becketqin commented on a change in pull request #8632: [FLINK-12744][ml] add
shared params in ml package
URL: https://github.com/apache/flink/pull/8632#discussion_r293227169
##########
File path:
flink-ml-parent/flink-ml-api/src/main/java/org/apache/flink/ml/api/misc/param/ParamInfo.java
##########
@@ -67,7 +67,7 @@ public String getName() {
* @return the aliases of the parameter
*/
public String[] getAlias() {
- return alias;
+ return alias == null ? new String[0] : alias;
Review comment:
Existing code, should we have a sanity check to make sure that `alias` array
does not contain null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
