zentol commented on a change in pull request #8687: [FLINK-12612][coordination]
Track stored partition on the TaskExecutor
URL: https://github.com/apache/flink/pull/8687#discussion_r293330753
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptorTest.java
##########
@@ -104,6 +104,24 @@ public void testSerializationWithNettyShuffleDescriptor()
throws Exception {
assertThat(shuffleDescriptorCopy.getConnectionId(),
is(connectionID));
}
+ @Test
+ public void testManagedExternallyFlag() {
+ for (ResultPartitionType partitionType :
ResultPartitionType.values()) {
+ ResultPartitionDeploymentDescriptor partitionDescriptor
= new ResultPartitionDeploymentDescriptor(
+ new PartitionDescriptor(resultId, partitionId,
partitionType, numberOfSubpartitions, connectionIndex),
+ (ShuffleDescriptor) ResultPartitionID::new,
Review comment:
addressed in #8654.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
