StefanRRichter commented on a change in pull request #8692: [FLINK-12804]
Introduce mailbox-based ExecutorService
URL: https://github.com/apache/flink/pull/8692#discussion_r293336048
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxImpl.java
##########
@@ -158,44 +174,108 @@ public boolean tryPutMail(@Nonnull Runnable letter) {
}
@Override
- public void putMail(@Nonnull Runnable letter) throws
InterruptedException {
+ public void putMail(@Nonnull Runnable letter) throws
InterruptedException, MailboxStateException {
Review comment:
From how the mailbox is threated in the PR, it is more of a datastructure to
track runnable objects and acts somewhat like a queue. Not sure if I would
implement knowledge about threads and what threads are allowed to do what here.
This is now implemented on the level of the executor, i.e. the user-facing
facade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
