aljoscha commented on a change in pull request #8723: [FLINK-12827][table-planner] Extract Optimizer from TableEnvImpl URL: https://github.com/apache/flink/pull/8723#discussion_r293334727
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/BatchOptimizer.scala ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.plan + +import org.apache.calcite.rel.RelNode +import org.apache.calcite.sql2rel.RelDecorrelator +import org.apache.calcite.tools.RuleSet +import org.apache.flink.table.calcite.CalciteConfig +import org.apache.flink.table.plan.nodes.FlinkConventions +import org.apache.flink.table.plan.rules.FlinkRuleSets +import org.apache.flink.table.planner.PlanningConfigurationBuilder + +/** + * An [[Optimizer]] that can be used for optimizing a batch plan. + * + * @param calciteConfig provider for [[CalciteConfig]]. It is a provider because the + * [[org.apache.flink.table.api.TableConfig]] in a + * [[org.apache.flink.table.api.TableEnvImpl]] is mutable. + * @param planningConfigurationBuilder provider for [[org.apache.calcite.plan.RelOptPlanner]] and + * [[org.apache.calcite.plan.Context]] + */ +class BatchOptimizer( + calciteConfig: () => CalciteConfig, + planningConfigurationBuilder: PlanningConfigurationBuilder) + extends Optimizer(calciteConfig, planningConfigurationBuilder) { + + /** + * Generates the optimized [[RelNode]] tree from the original relational node tree. + * + * @param relNode The original [[RelNode]] tree + * @return The optimized [[RelNode]] tree + */ + def optimize(relNode: RelNode): RelNode = { + val convSubQueryPlan = optimizeConvertSubQueries(relNode) + val expandedPlan = optimizeExpandPlan(convSubQueryPlan) + val decorPlan = RelDecorrelator.decorrelateQuery(expandedPlan) + val normalizedPlan = optimizeNormalizeLogicalPlan(decorPlan) + val logicalPlan = optimizeLogicalPlan(normalizedPlan) + optimizePhysicalPlan(logicalPlan, FlinkConventions.DATASET) + } + + /** + * Returns the built-in normalization rules that are defined by the environment. Review comment: I guess these are not defined by the environment anymore but by the optimiser. Probably the same in the `StreamOptimizer`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
