uce commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r293342768
########## File path: docs/concepts/glossary.md ########## @@ -0,0 +1,166 @@ +--- +title: Glossary +nav-pos: 3 +nav-title: Glossary +nav-parent_id: concepts +--- +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +#### Flink Application Cluster Review comment: I do like the proposed name and I'd be happy to call it application cluster going forward myself. I think having slight misalignment with internal class naming is acceptable, but I'd suggest to update user facing references to job cluster if we keep the renaming: * https://ci.apache.org/projects/flink/flink-docs-release-1.8/ops/deployment/kubernetes.html#flink-job-cluster-on-kubernetes * https://github.com/apache/flink/tree/master/flink-container/docker * https://github.com/apache/flink/tree/master/flink-container/kubernetes Otherwise I would be afraid of ending up in a situation with inconsistent names which can be confusing to users. Since I am not involved in the day to day development of this component, I would leave the decision to @tillrohrmann whether we can change it at this point. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
