zentol commented on issue #8654: [FLINK-12647][network] Add feature flag to 
disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#issuecomment-501715589
 
 
   @tillrohrmann I implemented both of your suggestions.
   
   I like the renaming of externallyManaged to releasedOnConsumption; it makes 
things a lot easier to understand.
   
   As for the ResultPartition sub-class, the empty `pin()` method in the 
base-class is a bit odd, but otherwise I like it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to