xuyang1706 commented on issue #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#issuecomment-501743582 > @xuyang1706 Thanks for updating the patch. I left a few more minor comments. > > It might be important to define and explain the following things in `ParamInfo` Java doc > > 1. Semantic of `optional`. > 2. Whether a `null` value is acceptable, including for the default value. The current code does not allow user to set a parameter to null (it will be treated as not set), but the default value could be null. OK, we have explained them in `ParamInfo` Java doc, supported 'null' value and added more test cases.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
