StefanRRichter commented on a change in pull request #8322: [FLINK-12364]
Introduce a CheckpointFailureManager to centralized manage checkpoint failure
URL: https://github.com/apache/flink/pull/8322#discussion_r293540733
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1384,4 +1389,27 @@ public void run() {
});
}
}
+
+ private void failPendingCheckpoint(
+ final PendingCheckpoint pendingCheckpoint,
+ final CheckpointFailureReason reason,
+ final Throwable cause) {
+
+ CheckpointException exception = new CheckpointException(reason,
cause);
+
+ if (cause != null) {
+ pendingCheckpoint.abort(reason, cause);
Review comment:
When I look into the implementation of the two abort methods that are
distinguished here, the `if` block seems unnecessary, I would just always call
`pendingCheckpoint.abort(reason, cause);` and probably annotate the `cause`
parameter as `@Nullable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
