JingsongLi commented on a change in pull request #8682:
[FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce
conversion overhead to blink
URL: https://github.com/apache/flink/pull/8682#discussion_r293643294
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/typeutils/BaseRowSerializer.java
##########
@@ -165,49 +168,33 @@ public int getArity() {
/**
* Convert base row to binary row.
- * TODO modify it to code gen, and reuse BinaryRow&BinaryRowWriter.
+ * TODO modify it to code gen.
Review comment:
We still need take this logical to code gen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
