Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-140335366
IMO, it would be better to wrap the `stopExecution` call in the
`TaskManager` into a `Future`. This has the following reasons: First of all,
with the current implementation, you'll miss all exceptions which occur in the
`stop` method. Secondly, you will send a positive `TaskOperationResult` back
before the stopping was executed. I haven't checked the semantic of the
`TaskOperationResult` but it might be the case that the JM upon receiving this
messages thinks that the stop call was successfully executed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
