ifndef-SleePy commented on a change in pull request #8721:
[FLINK-12823][datastream] PartitionTransformation supports DataExchan…
URL: https://github.com/apache/flink/pull/8721#discussion_r293739787
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
##########
@@ -428,7 +436,11 @@ private void addEdgeInternal(Integer upStreamVertexID,
}
}
- StreamEdge edge = new StreamEdge(upstreamNode,
downstreamNode, typeNumber, outputNames, partitioner, outputTag);
+ if (shuffleMode == null) {
Review comment:
Yes, it can be null here. Because there might be no
`PartitionTransformation` if user do not specify explicitly. And then
`partitioner` and `shuffleMode` would be null here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
