StephanEwen commented on a change in pull request #8346: [FLINK-12405] 
[DataSet] Introduce BLOCKING_PERSISTENT result partition type
URL: https://github.com/apache/flink/pull/8346#discussion_r293857231
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionType.java
 ##########
 @@ -49,13 +59,17 @@
        /** Does this partition use a limited number of (network) buffers? */
        private final boolean isBounded;
 
+       /** This partition will not be released after consuming if 
'isPersistent' is true. */
+       private final boolean isPersistent;
 
 Review comment:
   I agree that BLOCKING_PERSISTENT is not the best name.
   The specific thing is that it lives across jobs, but I am not sure what a 
good name for that would be.
   "global" and "external" both go in that direction...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to