mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics]
Support retention policy for InfluxDB metrics …
URL: https://github.com/apache/flink/pull/8668#discussion_r294030972
##########
File path:
flink-metrics/flink-metrics-influxdb/src/test/java/org/apache/flink/metrics/influxdb/InfluxdbReporterTest.java
##########
@@ -96,33 +96,36 @@ public void testMetricRegistration() throws Exception {
@Test
public void testMetricReporting() throws Exception {
- MetricRegistryImpl metricRegistry = createMetricRegistry();
+ String retentionPolicy = "one_hour";
+ MetricRegistryImpl metricRegistry =
createMetricRegistry(retentionPolicy);
try {
String metricName = "TestCounter";
Counter counter = registerTestMetric(metricName,
metricRegistry);
counter.inc(42);
stubFor(post(urlPathEqualTo("/write"))
- .willReturn(aResponse()
- .withStatus(200)));
+ .willReturn(aResponse()
+ .withStatus(200)));
Review comment:
@1u0, @Myasuka - Please let me know if I can resolve this issue and if there
is anything else required for this PR. Thanks for your advice.
Mans
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
