Myasuka commented on a change in pull request #8322: [FLINK-12364] Introduce a
CheckpointFailureManager to centralized manage checkpoint failure
URL: https://github.com/apache/flink/pull/8322#discussion_r294053508
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java
##########
@@ -252,6 +255,22 @@ public void setFailOnCheckpointingErrors(boolean
failOnCheckpointingErrors) {
this.failOnCheckpointingErrors = failOnCheckpointingErrors;
}
+ /**
+ * Get the tolerable checkpoint failure number which used by the
checkpoint failure manager
+ * to determine when we need to fail the job.
+ */
+ public int getTolerableCheckpointFailureNumber() {
+ return tolerableCheckpointFailureNumber;
+ }
+
+ /**
+ * Set the tolerable checkpoint failure number, the default value is 0
that means
+ * we do not tolerance any checkpoint failure.
+ */
+ public void setTolerableCheckpointFailureNumber(int
tolerableCheckpointFailureNumber) {
Review comment:
I noticed that you have introduced variable
`tolerableCheckpointFailureNumber` and related setter here. However, I cannot
see any method to call this method. Why not introduce related configuration in
`CheckpointingOptions` so that user could configure this variable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
