yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a
CheckpointFailureManager to centralized manage checkpoint failure
URL: https://github.com/apache/flink/pull/8322#discussion_r294066885
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java
##########
@@ -252,6 +255,22 @@ public void setFailOnCheckpointingErrors(boolean
failOnCheckpointingErrors) {
this.failOnCheckpointingErrors = failOnCheckpointingErrors;
}
+ /**
+ * Get the tolerable checkpoint failure number which used by the
checkpoint failure manager
+ * to determine when we need to fail the job.
+ */
+ public int getTolerableCheckpointFailureNumber() {
+ return tolerableCheckpointFailureNumber;
+ }
+
+ /**
+ * Set the tolerable checkpoint failure number, the default value is 0
that means
+ * we do not tolerance any checkpoint failure.
+ */
+ public void setTolerableCheckpointFailureNumber(int
tolerableCheckpointFailureNumber) {
Review comment:
IMO, you are wrong. `CheckpointingOptions` defines some global config
options which almost are related to the **state**. But
`tolerableCheckpointFailureNumber ` a checkpoint specific config option belongs
per job and it will enhance the config option of
`setFailOnCheckpointingErrors`. It should not be defined in
`CheckpointingOptions`. Currently, is it not used? Yes. Because we split this
feature into three steps. It will be used in the third step. But in this step,
we need it to create the `CheckpointFailureManager`. I think you know the
reason now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
