wuchong commented on a change in pull request #8736: [FLINK-12846][table] Carry primary key and unique key information in TableSchema URL: https://github.com/apache/flink/pull/8736#discussion_r294125081
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java ########## @@ -43,7 +44,28 @@ import static org.apache.flink.table.types.utils.TypeConversions.fromLegacyInfoToDataType; /** - * A table schema that represents a table's structure with field names and data types. + * <p>A table schema that represents a table's structure with field names and data types and some + * constraint information (e.g. primary key, unique key).</p><br/> + * + * <p>Concepts about primary key and unique key:</p> Review comment: The difference between primary key and unique key is that there is only one primary key and there can be more than one unique key. And a primary key doesn't need to be declared in unique key list again. I will add this to the class Javadoc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
