gaoyunhaii commented on a change in pull request #8704: [FLINK-12812][runtime]
Set resource profiles for task slots
URL: https://github.com/apache/flink/pull/8704#discussion_r294159237
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/types/ResourceProfileTest.java
##########
@@ -31,10 +31,10 @@
@Test
public void testMatchRequirement() throws Exception {
- ResourceProfile rp1 = new ResourceProfile(1.0, 100, 100, 100,
0, Collections.emptyMap());
- ResourceProfile rp2 = new ResourceProfile(1.0, 200, 200, 200,
0, Collections.emptyMap());
- ResourceProfile rp3 = new ResourceProfile(2.0, 100, 100, 100,
0, Collections.emptyMap());
- ResourceProfile rp4 = new ResourceProfile(2.0, 200, 200, 200,
0, Collections.emptyMap());
+ ResourceProfile rp1 = new ResourceProfile(1.0, 100, 100, 100,
0, 0, Collections.emptyMap());
+ ResourceProfile rp2 = new ResourceProfile(1.0, 200, 200, 200,
0, 0, Collections.emptyMap());
+ ResourceProfile rp3 = new ResourceProfile(2.0, 100, 100, 100,
0, 0, Collections.emptyMap());
+ ResourceProfile rp4 = new ResourceProfile(2.0, 200, 200, 200,
0, 0, Collections.emptyMap());
Review comment:
Do we need to add a test for the newly added `approximate` method ？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
