zhijiangW opened a new pull request #8761: [FLINK-12842][network] Fix invalid check released state during ResultPartition#createSubpartitionView URL: https://github.com/apache/flink/pull/8761 ## What is the purpose of the change *Currently in `ResultPartition#createSubpartitionView` it would check whether this partition is released before creating view. But this check is based on `refCnt != -1` which seems invalid, because the reference counter would not always reflect the released state.* *In the case of `ResultPartition#release/fail`, the reference counter is not set to -1. Even if in the case of `ResultPartition#onConsumedSubpartition`, the reference counter seems also no chance to be -1. So we could check the real `isReleased` state during creating view instead of reference counter.* ## Brief change log - *Remove check reference counter while `ReleaseOnConsumptionResultPartition#createSubpartitionView`* - *Add check `isReleased` state while `ResultPartition#createSubpartitionView`* - *Add tests in `ResultPartitionTest` and `ResultPartitionManagerTest`* ## Verifying this change Adds new tests in `ResultPartitionTest#testCreateSubpartitionOnFailingPartition` and `ResultPartitionManagerTest#testCreateViewForReleasePartition`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
