KurtYoung commented on a change in pull request #8758: [FLINK-12867] Add insert 
overwrite grammar as HIVE dialect
URL: https://github.com/apache/flink/pull/8758#discussion_r294212494
 
 

 ##########
 File path: 
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichSqlInsert.java
 ##########
 @@ -30,18 +30,22 @@
 import org.apache.calcite.sql.parser.SqlParserPos;
 
 import java.util.LinkedHashMap;
+import java.util.List;
 
 /** A {@link SqlInsert} that have some extension functions like partition, 
overwrite. **/
 public class RichSqlInsert extends SqlInsert implements ExtendedSqlNode {
        private final SqlNodeList staticPartitions;
 
+       private final SqlNodeList keywords2;
 
 Review comment:
   extendedKeywords will be better than meaningless number

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to