zhijiangW opened a new pull request #8763: [FLINK-12843][network] Refactor the pin logic in ReleaseOnConsumptionResultPartition URL: https://github.com/apache/flink/pull/8763 ## What is the purpose of the change *The pin logic is for adding the reference counter based on number of subpartitions for `ReleaseOnConsumptionResultPartition`. It seems not necessary to do it in while loop as now, because the atomic counter would not be accessed by other threads during pin. If the `ReleaseOnConsumptionResultPartition` was not created yet, the `createSubpartitionView` would not be called actually resulting in`PartitionNotFoundException`. So we could simple increase the reference counter in `ReleaseOnConsumptionResultPartition` constructor directly.* ## Brief change log - *Remove `pin` method in `ResultPartition`* - *Remove `pin` method in `ReleaseOnConsumptionResultPartition` and adds the ref counter in constructor* ## Verifying this change *Covered by `ReleaseOnConsumptionResultPartitionTest`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
