dawidwys commented on a change in pull request #8661: [FLINK-12711][table]
Separate function implementation and definition
URL: https://github.com/apache/flink/pull/8661#discussion_r294344774
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionLookup.java
##########
@@ -16,19 +16,44 @@
* limitations under the License.
*/
-package org.apache.flink.table.expressions.catalog;
+package org.apache.flink.table.catalog;
import org.apache.flink.annotation.Internal;
import org.apache.flink.table.functions.FunctionDefinition;
+import java.util.Optional;
+
/**
- * Catalog of functions that can resolve the name of a function to a {@link
FunctionDefinition}.
+ * Catalog of functions that can resolve the name of a function to a {@link
FunctionLookup.Result}.
*/
@Internal
-public interface FunctionDefinitionCatalog {
+public interface FunctionLookup {
Review comment:
True, that we do return the object identifier, but it is still closer to
`FunctionDefinition` than to e.g. Scalar**Function**, Aggregate**Function**
etc. But that was a minor suggestion. I am absolutely fine with that name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
