azagrebin commented on a change in pull request #8778:
[FLINK-12615][coordination] Track partitions on JM
URL: https://github.com/apache/flink/pull/8778#discussion_r294858360
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1061,6 +1063,20 @@ void markFinished(Map<String, Accumulator<?, ?>>
userAccumulators, IOMetrics met
IntermediateResultPartition[] allPartitions = finishedPartition
.getIntermediateResult().getPartitions();
+
PartitionTable<ResourceID> partitionTable =
vertex.getExecutionGraph().getPartitionTable();
+ for
(IntermediateResultPartition partition : allPartitions) {
+
ResultPartitionDeploymentDescriptor descriptor =
producedPartitions.get(partition.getPartitionId());
+ if
(!descriptor.isReleasedOnConsumption()) {
Review comment:
At the end we should also take into account whether this partition actually
occupies local resources (see
https://issues.apache.org/jira/browse/FLINK-12890) otherwise TM and its
connection can be released independently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
