bowenli86 commented on a change in pull request #8769: [FLINK-12875][hive]
support converting input args of char, varchar, bytes, timestamp, date for Hive
functions
URL: https://github.com/apache/flink/pull/8769#discussion_r294982933
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java
##########
@@ -119,9 +141,45 @@ public static HiveObjectConversion
getConversion(ObjectInspector inspector) {
} else {
return IdentityConversion.INSTANCE;
}
+ } else if (inspector instanceof
JavaDateObjectInspector) {
+ if (((JavaDateObjectInspector)
inspector).preferWritable()) {
Review comment:
After doing some research,I think actually there is no need to check
`preferWritable()`at all given input will be of primitive typed inspector. I
will have a immediate following PR to take care of this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
