Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1133#discussion_r39526103
  
    --- Diff: 
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/runtime/operators/TriggerTimer.java
 ---
    @@ -0,0 +1,119 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.runtime.operators;
    +
    +import org.apache.flink.runtime.taskmanager.DispatcherThreadFactory;
    +
    +import java.util.concurrent.Executors;
    +import java.util.concurrent.ScheduledExecutorService;
    +import java.util.concurrent.TimeUnit;
    +
    +/**
    + * A timer that triggers targets at a specific point in the future. This 
timer executes single-threaded,
    + * which means that never more than one trigger will be executed at the 
same time.
    + * <p>
    + * This timer generally maintains order of trigger events. This means that 
for two triggers scheduled at
    + * different times, the one scheduled for the later time will be executed 
after the one scheduled for the
    + * earlier time.
    + */
    +public class TriggerTimer {
    +   
    +   /** The thread group that holds all trigger timer threads */
    +   public static final ThreadGroup TRIGGER_THREADS_GROUP = new 
ThreadGroup("Triggers");
    +   
    +   /** The executor service that */
    --- End diff --
    
    ah, right ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to