Aitozi commented on issue #8455: [FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#issuecomment-503418125 Thanks @zhijiangW for your careful review. About this comment > covering the drainBuffer with three asserts together if possible I think it's not so good, because the second and the third assert depend on the previous drainBuffer action means if add the assert in the drainBuffer, `drainBuffer` will be a function with state Other comments has all been resolved, please have a look again, very thanks :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
