twalthr commented on a change in pull request #8781:
[FLINK-12874][table-common] Improve the semantics of zero length strings
URL: https://github.com/apache/flink/pull/8781#discussion_r295168960
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/BinaryType.java
##########
@@ -91,9 +92,11 @@ private BinaryType(int length, boolean isNullable) {
* For consistent behavior, the same logic applies to binary strings.
*
* <p>This method enables this special kind of binary string.
+ *
+ * <p>Zero-length binary strings have no serializable string
representation.
*/
public static BinaryType ofEmptyLiteral() {
- return new BinaryType(EMPTY_LITERAL_LENGTH, false);
+ return new BinaryType(EMPTY_LITERAL_LENGTH, true);
Review comment:
Agreed. I did this change because by default types in SQL are always
nullable, but we don't need to do it for this special case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
