dawidwys commented on a change in pull request #8707: [FLINK-12815] [table-planner-blink] Supports CatalogManager in blink planner URL: https://github.com/apache/flink/pull/8707#discussion_r295173029
########## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/operations/RichTableSourceQueryOperation.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.operations; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.plan.stats.FlinkStatistic; +import org.apache.flink.table.sources.TableSource; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +/** + * A {@link TableSourceQueryOperation} with {@link FlinkStatistic} and qualifiedName. + */ +@Internal +public class RichTableSourceQueryOperation<T> extends TableSourceQueryOperation<T> { + private final FlinkStatistic statistic; + private List<String> qualifiedName; Review comment: Why do we need the qualifiedName? Where does the qualified name comes from? The purpose of having TableSourceQueryOperation/DataStreamQueryOperation to not have a connection to the catalog, as they are created when e.g. `fromTableSource(TableSource)` or `fromDataStream(DataStream)` which is an inline operation. If I understand it correctly this is needed for your tests to have a deterministic naming. To be honest I think this shows a problem in the tests infrastructure. As a workaround though I would change the `List<String> qualifiedName` to `String uniqueId`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
