Xpray commented on a change in pull request #8756: [FLINK-12406] [Runtime]
Report BLOCKING_PERSISTENT result partition meta back to client
URL: https://github.com/apache/flink/pull/8756#discussion_r295189117
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -814,6 +820,69 @@ public Executor getFutureExecutor() {
entry -> serializeAccumulator(entry.getKey(),
entry.getValue())));
}
+ @Override
+ public BlockingPersistentResultPartitionMeta
getBlockingPersistentResultPartitionMeta() {
+ Map<AbstractID, Map<AbstractID, ResultPartitionDescriptor>>
resultPartitionDescriptors = new HashMap<>();
+
+ // keep record of all failed IntermediateDataSetID
+ Set<AbstractID> failedIntermediateDataSetIds = new HashSet<>();
+
+ for (ExecutionVertex executionVertex :
getAllExecutionVertices()) {
+ for (IntermediateResultPartition
intermediateResultPartition : executionVertex.getProducedPartitions().values())
{
+ if (intermediateResultPartition.getResultType()
== ResultPartitionType.BLOCKING_PERSISTENT) {
+ try {
+
addLocation(resultPartitionDescriptors, intermediateResultPartition);
+ } catch (Throwable throwable) {
+ LOG.error("Failed to Failed to
get location of ResultPartition: " +
intermediateResultPartition.getPartitionId(), throwable);
+
failedIntermediateDataSetIds.add(
+ new
AbstractID(intermediateResultPartition.getIntermediateResult().getId()));
Review comment:
Thanks for the review @shuiqiangchen. I'll see what I can do to deliver
these causes to the client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
