dawidwys commented on a change in pull request #8790: [FLINK-12710][table]
Prepare expressions for a new resolved expression
URL: https://github.com/apache/flink/pull/8790#discussion_r295190153
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/UnresolvedCallExpression.java
##########
@@ -45,13 +45,19 @@ public UnresolvedCallExpression(FunctionDefinition
functionDefinition, List<Expr
this.args = Collections.unmodifiableList(new
ArrayList<>(Preconditions.checkNotNull(args)));
}
+ public FunctionDefinition getFunctionDefinition() {
+ return functionDefinition;
+ }
+
@Override
- public List<Expression> getChildren() {
- return this.args;
+ public String asSummaryString() {
+ final List<String> argList =
args.stream().map(Object::toString).collect(Collectors.toList());
Review comment:
nit: you could do `collect(Collectors.joining("(", ", ", ")");`
Feel free to ignore though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
