godfreyhe commented on a change in pull request #8707: [FLINK-12815]
[table-planner-blink] Supports CatalogManager in blink planner
URL: https://github.com/apache/flink/pull/8707#discussion_r295262988
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/plan/QueryOperationConverter.java
##########
@@ -130,8 +138,39 @@ public RelNode visit(QueryOperation other) {
}
@Override
- public <U> RelNode visit(TableSourceQueryOperation<U>
tableSourceTable) {
- throw new UnsupportedOperationException("Unsupported
now");
+ public <U> RelNode visit(TableSourceQueryOperation<U>
tableSourceOperation) {
+ TableSource<?> tableSource =
tableSourceOperation.getTableSource();
+ boolean isBatch = tableSourceOperation.isBatch();
Review comment:
There is a special case: `LookupableTableSource`, which extends
`TableSource`. so the `isBatch` will also be used here if a
`TableSourceQueryOperation` wraps a `LookupableTableSource`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
