aljoscha commented on a change in pull request #8695: [FLINK-12805][FLINK-12808][FLINK-12809][table-api] Introduce PartitionableTableSource and PartitionableTableSink and OverwritableTableSink URL: https://github.com/apache/flink/pull/8695#discussion_r295336514
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/PartitionableTableSource.java ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.sources; + +import java.util.List; +import java.util.Map; + +/** + * Adds support for partition pruning to a [[TableSource]]. + * A {@link TableSource} extending this interface is a partition table and able to + * prune partitions for reducing reading data and reducing reading partition + * metadata (especially there are thousands of partitions). + * + * <p>Partitions is represented as a {@code Map<String, String>} which maps from partition-key + * to value. The partition columns and values are NOT of strict order in the Map. The correct + * order of partition fields should be provided by {@link #getPartitionKeys()}. + */ +public interface PartitionableTableSource { + + /** + * Gets all partitions as key-value map belong to this table. Review comment: ```suggestion * Returns the partitions of this {@link PartitionableTableSource}. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
