zentol commented on a change in pull request #8789: [FLINK-12890] Add partition
lifecycle related Shuffle API
URL: https://github.com/apache/flink/pull/8789#discussion_r295711577
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleDescriptor.java
##########
@@ -57,6 +58,11 @@ public ResultPartitionID getResultPartitionID() {
return resultPartitionID;
}
+ @Override
+ public Optional<ResourceID> hasLocalResources() {
Review comment:
you know, whenever I see this method I always first assume that it returns a
boolean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
