tillrohrmann commented on a change in pull request #8783:
[FLINK-12863][FLINK-12865] Remove concurrency from HeartbeatManager(Sender)Impl
URL: https://github.com/apache/flink/pull/8783#discussion_r295736211
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerSenderImpl.java
##########
@@ -36,54 +34,43 @@
*/
public class HeartbeatManagerSenderImpl<I, O> extends HeartbeatManagerImpl<I,
O> implements Runnable {
- private final ScheduledFuture<?> triggerFuture;
+ private final long heartbeatPeriod;
- public HeartbeatManagerSenderImpl(
- long heartbeatPeriod,
- long heartbeatTimeout,
- ResourceID ownResourceID,
- HeartbeatListener<I, O> heartbeatListener,
- ScheduledExecutor mainThreadExecutor,
- Logger log) {
+ HeartbeatManagerSenderImpl(
+ long heartbeatPeriod,
+ long heartbeatTimeout,
+ ResourceID ownResourceID,
+ HeartbeatListener<I, O> heartbeatListener,
+ ScheduledExecutor mainThreadExecutor,
+ Logger log) {
Review comment:
Good point. Will correct it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
