bowenli86 commented on a change in pull request #8785: [FLINK-11480][hive]
Create HiveTableFactory that creates TableSource/…
URL: https://github.com/apache/flink/pull/8785#discussion_r295963941
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/Catalog.java
##########
@@ -43,6 +45,16 @@
@PublicEvolving
public interface Catalog {
+ /**
+ * Get an optional {@link TableFactory} instance that's responsible to
generate source/sink for tables
Review comment:
```suggestion
* Get an optional {@link TableFactory} instance that's responsible for
generating source/sink for tables
```
Also, can you mention in javadoc when and where this is supposed to be
called? Audience may get confused on how this cooperates with table discovery
service.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
