sunjincheng121 commented on a change in pull request #8681:
[FLINK-12585][python] Align Stream/BatchTableEnvironment with JAVA Table API
URL: https://github.com/apache/flink/pull/8681#discussion_r296074512
##########
File path: flink-python/pyflink/table/table_config.py
##########
@@ -119,7 +116,7 @@ def get_built_in_database_name(self):
"""
return self._j_table_config.getBuiltInDatabaseName()
- def _set_built_in_database_name(self, built_in_database_name):
+ def set_built_in_database_name(self, built_in_database_name):
Review comment:
That makes sense to me (see the summary of my review #2) :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services