wuchong commented on a change in pull request #8730:
[FLINK-12834][table-planner-blink] Support CharType and BinaryType
URL: https://github.com/apache/flink/pull/8730#discussion_r296087906
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/typeutils/TypeCheckUtils.scala
##########
@@ -52,9 +52,14 @@ object TypeCheckUtils {
case _ => false
}
- def isVarchar(dataType: LogicalType): Boolean = dataType.getTypeRoot ==
VARCHAR
+ def isCharacterString(dataType: LogicalType): Boolean =
+
dataType.getTypeRoot.getFamilies.contains(LogicalTypeFamily.CHARACTER_STRING)
Review comment:
What about to move these mothods to common module? such as
`LogicalTypeChecks` class ? So that both blink-planner and blink-runtime can
use it. It is error-prune if we don't maintain is check in one place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
