becketqin commented on a change in pull request #8535: [FLINK-11693] Add
KafkaSerializationSchema that uses ProducerRecord
URL: https://github.com/apache/flink/pull/8535#discussion_r296131499
##########
File path:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
##########
@@ -2242,4 +2337,47 @@ public String getTargetTopic(Tuple3<Integer, Integer,
String> element) {
return element.f2;
}
}
+
+ private static class TestDeSerializer implements
KafkaDeserializationSchema<Tuple3<Integer, Integer, String>>,
Review comment:
Minor:
Can we have a private static deserializer class (may be abstract). And let
`TestDeserializer` and `Tuple2WithTopicSchema` extends that deserializer class
but implement different serializer interface?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
