zentol commented on a change in pull request #8804: [FLINK-12883][WIP][runtime]
Add elaborated partition release logic
URL: https://github.com/apache/flink/pull/8804#discussion_r296201927
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -1586,6 +1610,8 @@ public boolean updateState(TaskExecutionState state) {
if (attempt != null) {
try {
+ maybeReleasePartitions(attempt, state);
Review comment:
this must be done after the attempt is marked as finished. If the finishing
fails we might still need these partitions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
