[ 
https://issues.apache.org/jira/browse/FLINK-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790669#comment-14790669
 ] 

ASF GitHub Bot commented on FLINK-2566:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1135#discussion_r39652292
  
    --- Diff: 
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopology.java
 ---
    @@ -28,17 +28,14 @@
      * cannot be executed directly, but must be handed over to a {@link 
FlinkLocalCluster}, {@link FlinkSubmitter}, or
      * {@link FlinkClient}.
      */
    -class FlinkTopology extends StreamExecutionEnvironment {
    +public class FlinkTopology extends StreamExecutionEnvironment {
    --- End diff --
    
    That was on purpose on no bug. Because, a user should on call `new 
FlinkTopology()`.
    
    But now I need it to be public. Furthermore, and I am going to change some 
stuff and allow `new FlinkTopology()` (so I did not include a private 
constructor either in this PR -- for future purpose).


> FlinkTopologyContext not populated completely
> ---------------------------------------------
>
>                 Key: FLINK-2566
>                 URL: https://issues.apache.org/jira/browse/FLINK-2566
>             Project: Flink
>          Issue Type: Improvement
>          Components: Storm Compatibility
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> Currently FlinkTopologyContext is not populated completely. It only contains 
> enough information to make WordCount example work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to