wuchong commented on a change in pull request #8530:
[FLINK-12611][table-planner-blink] Make time indicator nullable in blink
URL: https://github.com/apache/flink/pull/8530#discussion_r296615594
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/schema/TimeIndicatorRelDataType.scala
##########
@@ -28,20 +28,17 @@ import java.lang
* as a basic SQL type.
*/
class TimeIndicatorRelDataType(
- typeSystem: RelDataTypeSystem,
- originalType: BasicSqlType,
+ val typeSystem: RelDataTypeSystem,
+ val originalType: BasicSqlType,
+ val nullable: Boolean,
val isEventTime: Boolean)
extends BasicSqlType(
typeSystem,
originalType.getSqlTypeName,
originalType.getPrecision) {
- override def equals(other: Any): Boolean = other match {
- case that: TimeIndicatorRelDataType =>
- super.equals(that) &&
- isEventTime == that.isEventTime
- case _ => false
- }
+ isNullable = nullable
Review comment:
nit: `this.isNullable = nullable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
