aljoscha commented on issue #8535: [FLINK-11693] Add KafkaSerializationSchema that uses ProducerRecord URL: https://github.com/apache/flink/pull/8535#issuecomment-504944235 Thanks @becketqin! I like your reviews, you are very thorough. 👌 I fixed the smaller things. I agree on the problem that the new `KafkaSerializerSchema` cannot completely subsume the old `KeyedSerializerSchema` + partitioner. I thought about how we should do that in the interface, if we might want to add other parameters to the method in the future. I was hesitant to introduce a context object for this, but we might have to do it. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
