xuyang1706 commented on a change in pull request #8776: [FLINK-12881][ml] Add more functionalities for ML Params and ParamInfo class URL: https://github.com/apache/flink/pull/8776#discussion_r296646908
########## File path: flink-ml-parent/flink-ml-api/src/main/java/org/apache/flink/ml/api/misc/param/ParamInfo.java ########## @@ -19,12 +19,25 @@ package org.apache.flink.ml.api.misc.param; import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.util.Preconditions; /** * Definition of a parameter, including name, type, default value, validator and so on. * * <p>This class is provided to unify the interaction with parameters. * + * <p>when isOptional is true, contain(ParamInfo) is true, it will return the value found in Params, Review comment: Thanks, your description is more clear. The default value in the non-optional parameter will never be used, I think it is not necessary to check this by extra codes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
